Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add layer definition for sequential models in pytorch component library. #205

Merged
merged 4 commits into from
Feb 25, 2023
Merged

Add layer definition for sequential models in pytorch component library. #205

merged 4 commits into from
Feb 25, 2023

Conversation

wmeddie
Copy link
Member

@wmeddie wmeddie commented Feb 10, 2023

Description

Adds a way to define a custom pytorch model inside a xircuits diagram.

image

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

Can cause issues for current xircuit files since it adds ports.

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Included a sample xircuits file.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Many more layers will be needed.

@MFA-X-AI MFA-X-AI marked this pull request as ready for review February 23, 2023 12:51
mansouralawi
mansouralawi approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@mansouralawi mansouralawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, the new pytorch components library and examples work as expected.

@mansouralawi mansouralawi merged commit 3242b8c into master Feb 25, 2023
@mansouralawi mansouralawi deleted the pytorch-layers branch February 25, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansouralawi mansouralawi mansouralawi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wmeddie @mansouralawi @MFA-X-AI