Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix links not rendering for unopened xircuits tab #191

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Aug 30, 2022

Description

This will allow links to be successfully render for the others unopened xircuits tabs every time refreshed/reloaded.

Note: There might be some delay when rendering points on link. Clicking on canvas should properly render it.

Actual Issue:

Actual_Links_Not_Render

Expected Fix:

Expected_Links_Not_Render

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Open multiple xircuits. Make sure all are properly linked.
  2. Refresh browser
  3. Every xircuits tabs should still be properly linked.
  4. Expect a delay when rendering the points. Clicking on canvas should fix it.
  5. Do steps 1-3 for the main branch. You should get the same as the gif in the Actual Issue above.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

There might be some delay when rendering points on link. Clicking on canvas should properly render it.

@AdrySky AdrySky added the bug Something isn't working label Aug 30, 2022
@AdrySky AdrySky requested a review from MFA-X-AI August 30, 2022 02:31
@AdrySky AdrySky self-assigned this Aug 30, 2022
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job pinpointing the way to reproduce that error, even more on getting the workaround.
Tested on my side, looks good. Nice work!

@MFA-X-AI MFA-X-AI merged commit e9f4fd6 into master Sep 2, 2022
@MFA-X-AI MFA-X-AI deleted the adry/fix-links-not-render branch September 2, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants