Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Disable canvas scrolled when scrolling description tooltip #185

Merged
merged 1 commit into from
Aug 3, 2022
Merged

🐛Disable canvas scrolled when scrolling description tooltip #185

merged 1 commit into from
Aug 3, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Aug 2, 2022 •
edited
Loading

Description

This will prevents propagation of the wheel event of canvas from being called.

References

This will fix #182

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Open node's description
  2. Try to use mouse wheel to scroll
  3. The canvas will not scroll

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the bug Something isn't working label Aug 2, 2022
@AdrySky AdrySky requested a review from MFA-X-AI August 2, 2022 03:28
@AdrySky AdrySky self-assigned this Aug 2, 2022
MFA-X-AI
MFA-X-AI approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great work!
fixed-scroll
Merging with main.

@MFA-X-AI MFA-X-AI merged commit 999e901 into master Aug 3, 2022
@MFA-X-AI MFA-X-AI deleted the adry/focus-wheel-event branch August 3, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canvas zooms in and out when user is scrolling the component description
2 participants
@AdrySky @MFA-X-AI