Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Enable Dynamic Component Library Installation from Wheel #181

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Jul 28, 2022

Description

This PR dynamically fetches the requirements for all xai_component libraries. To install a component, users would simply need to install by:
pip install xircuits[libName], ie pip install xircuits[pytorch].

This PR also removes requirements-full.txt as the full package version is dynamically fetched.

References

#122

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

As the package is not in pip yet, you'll need to download and install the wheel from the github action.

1. Verify Library Installation

  1. Get the wheel from the github action, setup venv.
  2. Try installing a component library package, ie pip install xircuits-1.4.0-py3-none-any.whl[pytorch]
  3. Verify that the xai_pytorch required libraries are installed via pip list.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Future component libraries dir should start with xai_, as I parsed the library name by chopping off the first underscore.

@MFA-X-AI MFA-X-AI changed the title Enable Component Library Installation from Wheel Enable Dynamic Component Library Installation from Wheel Jul 29, 2022
@MFA-X-AI MFA-X-AI marked this pull request as ready for review July 29, 2022 02:32
@yuenherny
Copy link
Contributor

@MFA-X-AI Might be a stupid question to ask, but how do I do the first part of "Get the wheel from the github action, setup venv."?

@MFA-X-AI MFA-X-AI changed the title Enable Dynamic Component Library Installation from Wheel ⚡ Enable Dynamic Component Library Installation from Wheel Jul 29, 2022
@MFA-X-AI MFA-X-AI requested a review from yuenherny July 29, 2022 03:46
Copy link
Contributor

@yuenherny yuenherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things worked as expected.

Got this in my pip list after running $ pip install xircuits-1.4.0-py3-none-any.whl[learning]:

keras                        2.9.0
Keras-Preprocessing          1.1.2
tensorboard                  2.9.1
tensorboard-data-server      0.6.1
tensorboard-plugin-wit       1.8.1
tensorflow                   2.9.1
tensorflow-estimator         2.9.0
tensorflow-io-gcs-filesystem 0.26.0

And these after running $ pip install xircuits-1.4.0-py3-none-any.whl[pytorch]:

torch                1.12.0
torchvision          0.13.0
tornado              6.2

@MFA-X-AI MFA-X-AI merged commit a58a783 into master Jul 29, 2022
@MFA-X-AI MFA-X-AI deleted the fahreza/comp-lib-installs branch July 29, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants