Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Able save points on link and add listener when moving node #165

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Jun 15, 2022

Description

This will enable to save points created on any link with a listener to detect its changes. The listener also included when moving node.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Points created still exist when reopen xircuits
    1. Open any example
    2. Try add points on any link
    3. Save
    4. Close and reopen xircuits
    5. Points created still exist
  2. Listener when moving node
    1. Make sure xircuits not in 'dirty' state
    2. Try moving node and release mouse button
    3. You will see xircuits is in 'dirty' state
  3. Listener when creating point
    1. Make sure xircuits not in 'dirty' state
    2. Try adding point on any link created and release mouse button
    3. You will see xircuits is in 'dirty' state

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the enhancement New feature or request label Jun 15, 2022
@AdrySky AdrySky requested a review from MFA-X-AI June 15, 2022 06:59
@AdrySky AdrySky self-assigned this Jun 15, 2022
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows, all 3 features

  1. Points created still exist when reopen xircuits
  2. Listener when moving node
  3. Listener when creating point

work flawlessly. Wasn't expecting (2) when first testing it out, was pleasantly surprised it worked how it is now. Bery much appreciated for those with large complicated Xircuits workflows. Great work!

@MFA-X-AI MFA-X-AI merged commit 09283ff into master Jun 16, 2022
@MFA-X-AI MFA-X-AI deleted the adry/save-points-on-link branch June 16, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants