Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix adding node via link #162

Merged
merged 3 commits into from
Jun 7, 2022
Merged

🐛Fix adding node via link #162

merged 3 commits into from
Jun 7, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Jun 7, 2022

Description

This will fix adding node via component panel or dropped link. Previously, when updating the package-lock file, this feature cannot be use. It's due to incorrect node position and somehow the sourcePort's data is missing(Not sure why).

References

#121

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. With latest update of package-lock.json
    1. Git clone new repo
    2. Delete package-lock.son and tsconfig.tsbuildinfo
    3. Install development as usual
    4. Create xircuits file
    5. Add node via component panel or dropped link
  2. Try also from the wheel

Note: Haven't tested both but I assumed it'll work.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Currently, the comment component is broken. It doesn't show the comment's textarea. Haven't figured out what causing this.
Also, the context menu's position is kinda wrong.

@AdrySky AdrySky added the bug Something isn't working label Jun 7, 2022
@AdrySky AdrySky requested a review from MFA-X-AI June 7, 2022 07:57
@AdrySky AdrySky self-assigned this Jun 7, 2022
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfix PR!
Can confirm that things work normally even by deleting the package.lock in both build and wheel. Will merge this now so I can test out in the other PRs, hopefully works as well. Good work!

@MFA-X-AI MFA-X-AI merged commit 27fa127 into master Jun 7, 2022
@MFA-X-AI MFA-X-AI deleted the adry/fix-add-node-unreal branch June 7, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants