Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ typo fix for pycaret component library #157

Merged
merged 1 commit into from
May 11, 2022
Merged

✏️ typo fix for pycaret component library #157

merged 1 commit into from
May 11, 2022

Conversation

annabelle1217
Copy link

@annabelle1217 annabelle1217 commented May 11, 2022

Welcome to Xircuits! Thank you for making a pull request. Please ensure that your pull request follows the template.

Description

Fix typo in xai_pytorch/training.py PrepareUnetDataLoader component

References

None

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

1. Test A

1. Reload node on Xircuits
2. Save and compile
3. Run

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Add if any.

@annabelle1217
Copy link
Author

Change highlighted "train" in image below to "test"
image

@yusufraji
Copy link
Contributor

Thanks for finding that. Let's ship it. 🚀

Is it possible to rename of tests to test as well? Like in tests_set, tests_loader e.t.c. What do you think about that @MFA-X-AI ?

@MFA-X-AI
Copy link
Member

@annabelle1217 thanks for the PR! Seems like that slipped our attention.

@yusufraji don't see why not. Just ensure that it can run the full workflow from start to finish.

@annabelle1217
Copy link
Author

annabelle1217 commented May 11, 2022

Great, will change the "tests" to "test"

@annabelle1217
Copy link
Author

Tested UnetTrain example with changed component, it runs well

Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for contributing to Xircuits. 😁

@annabelle1217
Copy link
Author

I found that my dataset used for testing still linger around in the Xircuit file, will remove it in another commit

@MFA-X-AI MFA-X-AI changed the title minor typo fix ✏️ typo fix for pycaret component library May 11, 2022
@MFA-X-AI MFA-X-AI merged commit 8ad45a5 into XpressAI:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants