Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Fix same type port cannot linked #155

Merged
merged 1 commit into from
Apr 27, 2022
Merged

🐛Fix same type port cannot linked #155

merged 1 commit into from
Apr 27, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Apr 27, 2022 •
edited
Loading

Description

This will allow link ports of same type.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Try connecting outPort of string type to inPort of string type

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the bug Something isn't working label Apr 27, 2022
@AdrySky AdrySky requested a review from MFA-X-AI April 27, 2022 04:19
@AdrySky AdrySky self-assigned this Apr 27, 2022
MFA-X-AI
MFA-X-AI approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was definitely one of the important bugs to fix before 1.4 release. Can confirm you can do port-to-port linkage again with the correct typing.
Glad to have it fixed. Great work!

@MFA-X-AI MFA-X-AI merged commit 0c9c4f4 into master Apr 27, 2022
@MFA-X-AI MFA-X-AI deleted the adry/allow-same-type-check branch April 27, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI