-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Xircuits Entry Handler for Components + Submodule Components Download #152
✨ Xircuits Entry Handler for Components + Submodule Components Download #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, this feature will be very useful for Xircuits built using the wheel.
Tests:
- Check normal Xircuits component command
Test Passed
- Check Xircuits component command from a specific branch
Test Failed
Ran command xircuits-components --branch xai_object_classification
- Check Xircuits submodule component command from a submodule
i. run xircuits-components --sublib componentLibraryName. For this example I will mostly use xai_pycaret. Verify that:
You can download the component library by using either xircuits-components --sublib xai_pycaret or --sublib pycaret
Test Passed
ii. Using the
--sublib
tag when multiple libraries have the same name will return the first instance (try--sublib xai
)
Test Passed
- It would be nice to print out the multiple libraries found and the downloaded first instance.
iii. Supplying a lib that does not exist will return an error message component library submodule not found.
Test Passed
iv. You can chain multiple libraries.
xircuits-components --sublib pycaret modelstash
Test Passed
- Check Xircuits Init, testing
xircuits-examples
Test Passed
- Recommended test after the fixes: Run the same testing process using a user without access to the private repo.
Thanks for the review,
should be fixed now.
I was actually planning to do this in this PR, however as I also want to implement a semi-persistent way of allowing users to store their access token securely, it'll be a new feature by itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
All technical tests passed successfully.
It will be nice to implement these:
- Progress bar for component library download.
- Print out the multiple libraries found and the downloaded first instance.
Awesome. For these last 2:
Added in 85b4cae and eb83dff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra features. both work fine.
Description
This PR introduces more console commands which focuses on downloading component libraries. While dev users using the cloned repo can use
git submodule init
andgit submodule update
to pull the xai_components, users downloading from pip will not be able to as it is no longer a git repository.This PR introduces the
xircuits-components
command that allows users to download them.References
If applicable, note issue numbers this pull request addresses. You can also note any other pull requests that address this issue and how this pull request is different.
Pull Request Type
Type of Change
Tests
1. Check normal Xircuits component command
xircuits-components
. Verify thatxai_components
have been downloaded.2. Check Xircuits component command from a specific branch
xircuits-components --branch branchName
. Verify that thexai_components
of that branch have been downloaded. For this you may try branch ``xai_object_classification`. The object_classification components should be there.3. Check Xircuits submodule component command from a submodule
xircuits-components --sublib componentLibraryName
. For this example I will mostly use xai_pycaret. Verify that:xircuits-components --sublib xai_pycaret
orxircuits-components --sublib pycaret
--sublib
tag when multiple libraries have the same name will return the first instance (try--sublib xai
)component library submodule not found.
xircuits-components --sublib pycaret modelstash
4. Check Xircuits Init
Check any of the previous
xircuits
console commands, likexircuits-examples
. It will always print the message and init .xircuits.Tested on?
Notes