-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Add Component's Description Tooltip #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for the PR
Feature: display tooltip of component's description. It gets the information from its script top level docstring(After class, before port information). works fine
After a few tests on this PR, I would like to point to some expected bugs:
- The description box persists on display after switching from the canvas to another tab
- The description box does not follow the component when zooming the canvas in/out or dragging the whole canvas
- The description box persists in front of the context menu
- Clicking on the output port removes the icon to open the discerption box. Need to reload node to make it appear again
- The description box can be activated on multiple components. However, one description box will serve them all. Here I suggest two possible fixes:
-If the description box is activated on one component, it deactivates the description boxes on all others.
- If the description box is activated on multiple components, each component gets a standalone description box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a great review, thanks @mansouralawi. The information panel does share some similarities with the error bubble, so I'll throw in a few comments.
- The description box persists on display after switching from the canvas to another tab
- The description box does not follow the component when zooming the canvas in/out or dragging the whole canvas
- The description box persists in front of the context menu
This also happens with the error bubble, the difference is that the bubble is dismissed after 1-2 seconds so it's not so noticeable. A quick fix would be to apply the same for the information panel, but long term we definitely want to dismiss it when changing tabs.
- Clicking on the output port removes the icon to open the discerption box. Need to reload node to make it appear again
This one was interesting. When you click on an outPort, it's treated as a drag and drop action, hence creating a link to the same port which throws out the error bubble. Definitely should look into it being rerendered though, possibly the state of the component.
- The description box can be activated on multiple components. However, one description box will serve them all. Here I suggest two possible fixes:
-If the description box is activated on one component, it deactivates the description boxes on all others.
- If the description box is activated on multiple components, each component gets a standalone description box.
While unintentional, I actually like the way it's being handled now. Users would typically only have attention towards one component description at a time, but if they have multiple info blocks active, it would have the moving animation (which indicates it was already active in another component). But yes, 1 info box at a time would reduce the visual cluster I think.
Thanks @mansouralawi & @MFA-X-AI for the feedback. I think it was a bit rushed of me making this PR as there are lot of bugs laying around. I could fix some issue if kept using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes, most of the pervious issues are solved, here a list of some of thee bugs I found.
- Overall the canvas is buggy when dragging the components or connections
Major Issue
, Better to be tested again on another device.
Thanks @mansouralawi for the review. So I fixed the latest bug issues. Though, not sure about the last issue mentioned,
Not sure what causing it. Let me know if it happen again. Thanks again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing that. |
Great work, feature works as expected. |
Description
This will display tooltip of component's description. It get the information from its script top level docstring(After class, before port information).
Pull Request Type
Type of Change
Tests
Tested on?