Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add console command to download examples + datasets #132

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Mar 29, 2022

Description

As we are now able to pull folders directly from the repo, adding a console command entry point for users to download examples is simple. With this PR, users can download the examples and datasets with xircuits-examples

References

#131

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

1. Test Download Examples & Datasets Feature

  1. Download the wheel from github action
  2. Install it. You'd probably want to install [full], pip install xircuits-1.2.0-py3-none-any.whl[full]
  3. Download the examples with command xircuits-examples
  4. Verify that examples and Datasets were downloaded
  5. Run with xircuits and verify that examples works as expected (KerasPredict.xircuits should be the fastest)

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

I've also changed the logic the tqdm progress bar from folders processed -> files downloaded in this PR.

@MFA-X-AI MFA-X-AI requested a review from AdrySky March 29, 2022 04:49
Copy link
Contributor

@AdrySky AdrySky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM. Thanks

@AdrySky AdrySky merged commit 87da1cb into master Mar 30, 2022
@AdrySky AdrySky deleted the fahreza/get-examples branch March 30, 2022 07:50
@MFA-X-AI MFA-X-AI mentioned this pull request Oct 4, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants