Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️Refactor customDeserializeModel #128

Merged
merged 1 commit into from
Mar 28, 2022
Merged

♻️Refactor customDeserializeModel #128

merged 1 commit into from
Mar 28, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Mar 25, 2022 •
edited
Loading

Description

This just refactor customDeserializeModel.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Make sure the dirty state still usable by adding/removing nodes

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky requested a review from MFA-X-AI March 25, 2022 08:12
@AdrySky AdrySky self-assigned this Mar 25, 2022
MFA-X-AI
MFA-X-AI approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Yep, RD stuff should be refactored to it's own part so the bodywidget isn't too bloated.
I've ran a few tests, aka:

  1. Create components and linking them together
  2. Running the canvas
  3. Same thing but multiple xircuits tabs
    Events seems to be properly exclusive to the canvas that is active.
    Good work!

@MFA-X-AI MFA-X-AI merged commit 5f9ea81 into master Mar 28, 2022
@MFA-X-AI MFA-X-AI deleted the adry/refactor-deserialize-model branch March 28, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI