Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨Add string msg when running xircuits #119

Merged
merged 1 commit into from
Mar 4, 2022
Merged

🎨Add string msg when running xircuits #119

merged 1 commit into from
Mar 4, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Mar 4, 2022 •
edited
Loading

Description

This will add xircuits logo string when running xircuits.

str logo

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Run xircuits should output the above art and string.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the enhancement New feature or request label Mar 4, 2022
@AdrySky AdrySky requested a review from MFA-X-AI March 4, 2022 08:05
@AdrySky AdrySky self-assigned this Mar 4, 2022
MFA-X-AI
MFA-X-AI approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. With this we don't have to wait for other libraries to load first (like TF GPU) to see if the Xircuits is running.
Tested and working!

@MFA-X-AI MFA-X-AI merged commit c7f798e into master Mar 4, 2022
@MFA-X-AI MFA-X-AI deleted the adry/run-output-str branch March 4, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI