Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't compile when doing spark submit #117

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Don't compile when doing spark submit #117

merged 1 commit into from
Mar 3, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Mar 3, 2022 •
edited
Loading

Description

This will only allow xircuits to compile when Run option is chosen.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Run xircuits with spark submit and see does it compile/update its python script. It shouldn't update it.
  2. Also, run xircuits with the default (Run) option and see does it compile/update its python script. It should still update it.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky requested a review from MFA-X-AI March 3, 2022 04:00
@AdrySky AdrySky self-assigned this Mar 3, 2022
MFA-X-AI
MFA-X-AI approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working. Needed to have a quick dev and troubleshooting for spark submit stuff. In the future we might want to make a warning that the going to run file is different from the current view of the Xircuits canvas.

@MFA-X-AI MFA-X-AI merged commit 83f4618 into master Mar 3, 2022
@MFA-X-AI MFA-X-AI deleted the adry/dont-compile-when-spark-submit branch March 3, 2022 04:15
@romina1601 romina1601 mentioned this pull request Dec 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI