Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 added custom loading logo #108

Merged
merged 4 commits into from
Feb 24, 2022
Merged

💄 added custom loading logo #108

merged 4 commits into from
Feb 24, 2022

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Feb 24, 2022 •
edited by AdrySky
Loading

Description

We have a new custom Xpress logo now~

Loading Screen mini

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. View New Loading Logo

    1. Launch Jupyterlab
    2. See logo
    3. Refresh Jupyterlab
    4. See logo again :D

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Thanks media team.

@MFA-X-AI MFA-X-AI requested a review from AdrySky February 24, 2022 02:06
AdrySky
AdrySky approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@AdrySky AdrySky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to whoever involve in creating that amazing gif.

I also took some liberty to change the favicon as well. Not the best way to do it but it'll do for now. Probably will change it when there a better way to handle it.

@AdrySky AdrySky merged commit 23e8d6b into master Feb 24, 2022
@AdrySky AdrySky deleted the fahreza/custom-loading-logo branch February 24, 2022 07:19
@MFA-X-AI MFA-X-AI changed the title added custom loading logo 💄 added custom loading logo Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrySky AdrySky AdrySky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MFA-X-AI @AdrySky