Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 updated wheel name in github action #103

Merged
merged 16 commits into from
Feb 16, 2022
Merged

🤖 updated wheel name in github action #103

merged 16 commits into from
Feb 16, 2022

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Feb 15, 2022 •
edited
Loading

Description

When downloading the github action artifacts, every file is named xircuits-wheel. For the sake of distinguishing which is which, I've added the branch name and the commit hash.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Documentation
  • Others (Please Specify): Github Action

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Check the artifact in this pull request. It should have the branch name and hash.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others: Github

@MFA-X-AI
updated wheel name in github action
76946be
@MFA-X-AI
2nd attempt of getting the branch and commit hash right
76d0a57
@MFA-X-AI
3rd attempt of getting the branch and commit hash right
47f4872
@MFA-X-AI
4th attempt of getting the branch and commit hash right
617c621
@MFA-X-AI
removed additional tag
8b7cdb3
@MFA-X-AI
5th attempt of getting the branch and commit hash right
96670a4
@MFA-X-AI
6th attempt of getting the branch and commit hash right
0776c69
@MFA-X-AI
7th attempt of getting the branch and commit hash right
ebc2755
@MFA-X-AI
8th attempt of getting the branch and commit hash right
c6d04fe
@MFA-X-AI
9th attempt of getting the branch and commit hash right
8a7fe08
@MFA-X-AI
10th attempt of getting the branch and commit hash right
bb68ca5
@MFA-X-AI
11th attempt of getting the branch and commit hash right
6ad1f2d
@MFA-X-AI
fix indent
5d9f5d4
@MFA-X-AI
12th attempt of getting the branch and commit hash right
9a66b0e
@MFA-X-AI
13th attempt of getting the branch and commit hash right
c6d2f7b
@MFA-X-AI
got the branch and commit hash right
60bbef7
@MFA-X-AI MFA-X-AI marked this pull request as ready for review February 16, 2022 01:34
@MFA-X-AI MFA-X-AI requested a review from AdrySky February 16, 2022 01:36
AdrySky
AdrySky approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@AdrySky AdrySky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrySky AdrySky merged commit 7527a0d into master Feb 16, 2022
@AdrySky AdrySky deleted the fahreza/update-wheel-action branch February 16, 2022 01:41
@MFA-X-AI MFA-X-AI changed the title updated wheel name in github action 🤖 updated wheel name in github action Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrySky AdrySky AdrySky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MFA-X-AI @AdrySky