Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Dispose output panel when no kernel selected #102

Merged
merged 1 commit into from
Feb 15, 2022
Merged

🐛Dispose output panel when no kernel selected #102

merged 1 commit into from
Feb 15, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Feb 15, 2022 •
edited
Loading

Description

This will fix the output panel broken when no kernel selected.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. When running any xircuits, don't pick any kernel.
    1. Click Run again.
    2. It should prompt to select a kernel.
    3. Select a kernel.
    4. Xircuits should be able to run as usual.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the bug Something isn't working label Feb 15, 2022
@AdrySky AdrySky requested a review from MFA-X-AI February 15, 2022 09:28
@AdrySky AdrySky self-assigned this Feb 15, 2022
MFA-X-AI
MFA-X-AI approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug confirmed squashed.
Test in Windows, when selecting cancel in kernel selection the output panel terminates.
Good work!

@MFA-X-AI MFA-X-AI merged commit ad5344c into master Feb 15, 2022
@MFA-X-AI MFA-X-AI deleted the adry/fix-when-no-kernel-selected branch February 15, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI