Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄Change into labIcon and replace the refresh icon #100

Merged
merged 6 commits into from
Feb 14, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Feb 14, 2022

Description

This will change some of the icons to use the LabIcon, icon class used by JupyterLab.

The icons changed into LabIcon are :

  1. xircuits
  2. debugger
  3. lock
  4. breakpoint

This also replace the refresh icon to xircuits's icon

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Make sure the changed icons are correct and render properly.
  2. Try refreshing the jupyterlab. It should render a xircuits's icon rather than jupyterlab's with the same orbit's icon.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Currently, there some icons still need the css class to be style. Icons can be styled by passing CSS parameters into .element(...) as shown here if needed to change into LabIcon

@AdrySky AdrySky added the enhancement New feature or request label Feb 14, 2022
@AdrySky AdrySky requested a review from MFA-X-AI February 14, 2022 06:48
@AdrySky AdrySky self-assigned this Feb 14, 2022
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick pull request!
Logo looks good, but the alignment is off on a different screen resolution.

alignment

I don't think this should be hardcoded.

#base.css
  left: 650px;
  top: 270px;

Good luck with it, there's a reason why centering divs is a popular joke. :D

@AdrySky
Copy link
Contributor Author

AdrySky commented Feb 14, 2022

Yeah, you're right. It shouldn't be hardcoded. I already fix it. Please review it at different resolution and check does it center with each resolution changed.

@AdrySky AdrySky requested a review from MFA-X-AI February 14, 2022 09:31
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Centered properly now. Great work!

@MFA-X-AI MFA-X-AI merged commit f4ea8b4 into master Feb 14, 2022
@MFA-X-AI MFA-X-AI deleted the adry/refresh-labIcon branch February 14, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants