Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 support #3807

Closed
totaam opened this issue Mar 27, 2023 · 2 comments
Closed

Python 3.12 support #3807

totaam opened this issue Mar 27, 2023 · 2 comments
Labels
enhancement New feature or request packaging

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 27, 2023

Fedora 38 ships with Python 3.12

Big problems:
@totaam totaam added enhancement New feature or request packaging labels Mar 27, 2023
totaam added a commit that referenced this issue Mar 27, 2023
@totaam
#3807 coerce setuptools
8e0a5b8
@totaam totaam mentioned this issue Mar 27, 2023
Closed
@totaam
Copy link
Collaborator Author

totaam commented Mar 28, 2023

There's another Cython problem: cython/cython#5284
And since we can only use newer Cython versions with Python 3.12, this is now a blocker.

@totaam totaam mentioned this issue Mar 28, 2023
Closed
totaam added a commit that referenced this issue Mar 29, 2023
@totaam
#3807 add explicit 'noexcept'
a3cd65e
totaam added a commit that referenced this issue Mar 29, 2023
@totaam
#3807 also add explicit 'noexcept' to pxd
c2d8425
totaam added a commit that referenced this issue Mar 29, 2023
@totaam
#3807 auto-apply the patch to fix builds with older versions of Cython
82062be
totaam added a commit that referenced this issue Mar 29, 2023
@totaam
#3807 CI unit tests just runs 'install'..
772044a 
so try to patch every time and live with the warning when we patch twice
@totaam totaam closed this as completed Mar 29, 2023
totaam added a commit that referenced this issue Mar 29, 2023
@totaam
#3807 use the same uint64_t definition in the pxd
73cc28b
totaam added a commit that referenced this issue Mar 29, 2023
@totaam
#3807 KISS: just make the pxd match the pyx
9cbd272 
no need for a patch, or autopatch in setup.py
totaam added a commit that referenced this issue Mar 29, 2023
@totaam
#3807 merge changes from git master: use uint64_t everywhere
a2ef126 
more correct and gives us better compatibility with various versions of Cython
@totaam
Copy link
Collaborator Author

totaam commented Apr 14, 2023

For now, we have:

xpra/setup.py

Line 285 in 4d62441

strict_ENABLED = sys.version_info<(3, 12) #3.12 has a lot of cython issues

totaam added a commit that referenced this issue Jul 19, 2023
@totaam
#3807 fix warnings with Python 3.12 and Cython 3.0
9102531
totaam added a commit that referenced this issue Jul 20, 2023
@totaam
#3807 Python 3.12 should now build without warnings
dc9dc70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request packaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam