Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for bfloat in VInsert PreLegalizerCombiner #243

Open
wants to merge 2 commits into
base: aie-public
Choose a base branch
from
Open

Add support for bfloat in VInsert PreLegalizerCombiner #243

wants to merge 2 commits into from

Conversation

abhinay-anubola
Copy link
Collaborator

@abhinay-anubola abhinay-anubola commented Nov 21, 2024 •
edited
Loading

Add support for bfloat in SetExtract PreLegalizerCombiner
Add support for bfloat in VInsert PreLegalizerCombiner

@abhinay-anubola abhinay-anubola force-pushed the sanubola.support.bf512.VInsertCombiner branch from d6afe1c to 85d6911 Compare November 21, 2024 13:48
gbossu
gbossu reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@gbossu gbossu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but I'm wondering if getting rid of aie2_set_bf512_bf256 in the frontend and using aie2_set_I512_I256 wouldn't be better

@abhinay-anubola abhinay-anubola force-pushed the sanubola.support.bf512.VInsertCombiner branch 2 times, most recently from 3b7692e to f10042d Compare November 25, 2024 08:44
@abhinay-anubola abhinay-anubola force-pushed the sanubola.support.bf512.VInsertCombiner branch from f10042d to 39c7708 Compare November 27, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnamtibrewala krishnamtibrewala krishnamtibrewala left review comments

@martien-de-jong martien-de-jong martien-de-jong left review comments

@gbossu gbossu gbossu left review comments

@andcarminati andcarminati andcarminati left review comments

@abnikant abnikant Awaiting requested review from abnikant abnikant is a code owner

@khallouh khallouh Awaiting requested review from khallouh khallouh is a code owner

@konstantinschwarz konstantinschwarz Awaiting requested review from konstantinschwarz konstantinschwarz is a code owner

@SagarMaheshwari99 SagarMaheshwari99 Awaiting requested review from SagarMaheshwari99 SagarMaheshwari99 is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abhinay-anubola @andcarminati @gbossu @martien-de-jong @krishnamtibrewala