Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitHTTP Config: Add capability to parse int in string format #3855

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

Fangliding
Copy link
Member

fix #3854

@Fangliding
Copy link
Member Author

“100” → 100
“-1” → -1
“” → 0

@Fangliding Fangliding merged commit 697156f into main Sep 28, 2024
36 checks passed
@Fangliding Fangliding deleted the int-in-string branch September 28, 2024 19:10
@RPRX
Copy link
Member

RPRX commented Sep 30, 2024

这个 PR 的槽点是 commit message 里的引号看起来是中文引号

这个 Int32Range 是只有 SplitHTTP 用到了吗

还有我想了下 "-2--1" 或者 "-2-5" 这种也可以写出解析,虽然暂时用不到

@Fangliding
Copy link
Member Author

这个 PR 的槽点是 commit message 里的引号看起来是中文引号

这个 Int32Range 是只有 SplitHTTP 用到了吗

还有我想了下 "-2--1" 或者 "-2-5" 这种也可以写出解析,虽然暂时用不到

唔 电脑是新的输入法还没调教好 而且chrome好像不是很能看出来(其实我也看到了 手机上挺明显的)

核心里能填range的不止一处 但是目前只有splithttp里用了 后续需要可以重构改上

说实话要兼容负号可能不如用波浪号 -2~-1 不过确实没什么用

@RPRX
Copy link
Member

RPRX commented Oct 2, 2024

虽然 release notes 还没写好,但我已将 v24.9.30 标为 latest

Xray-core 中有很多 IntRange,@Fangliding 你查找下,改为都用这个函数来解析吧

@RPRX RPRX changed the title 使splithttp可以正常解析以string形式输入的int SplitHTTP Config: Add capability to parse int in string format Oct 6, 2024
@RPRX
Copy link
Member

RPRX commented Oct 6, 2024

我正在写 v24.9.30 的 release notes,我发现改了 PR 标题后 Generate 的 What's Changed 也会改,这玩意儿可太方便了

leninalive pushed a commit to amnezia-vpn/amnezia-xray-core that referenced this pull request Oct 29, 2024
dragonbreath2000 pushed a commit to dragonbreath2000/Xray-core that referenced this pull request Dec 11, 2024
dragonbreath2000 pushed a commit to dragonbreath2000/Xray-core that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

splithttp xPaddingBytes format error
2 participants