Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-8543: Promote to warning instead of error. Promote some additional hints. #164

Merged
merged 3 commits into from
Nov 22, 2019

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Nov 22, 2019

Since we haven't actually published the 1.0.0 release yet, I added these rules to the v1.yaml file and we can just skip 1.0.0 and start by publishing 1.0.1 (i.e. it's not breaking)

@rmconsole-wf
Copy link

rmconsole-wf commented Nov 22, 2019

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

	When this pull is merged I will add it to the following release:
	Version: workiva_analysis_options 1.0.1
	Release Ticket(s): RM-62152

	This pull is considered the release of workiva_analysis_options 1.0.1 
	The options defined for this repo will be carried out


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Friday, November 22 12:59 PM CST

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@evanweible-wf evanweible-wf changed the title Promote some hints to errors Promote to warning instead of error. Promote some additional hints. Nov 22, 2019
@evanweible-wf evanweible-wf reopened this Nov 22, 2019
@rmconsole3-wf rmconsole3-wf changed the title Promote to warning instead of error. Promote some additional hints. CPLAT-8543 Promote to warning instead of error. Promote some additional hints. Nov 22, 2019
@charliekump-wf charliekump-wf changed the title CPLAT-8543 Promote to warning instead of error. Promote some additional hints. CPLAT-8543: Promote to warning instead of error. Promote some additional hints. Nov 22, 2019
@josephswanson-wf
Copy link

@rmconsole-wf

2 similar comments
@josephswanson-wf
Copy link

@rmconsole-wf

@josephswanson-wf
Copy link

@rmconsole-wf

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@todbachman-wf todbachman-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@evanweible-wf
Copy link
Contributor Author

QA +1
@Workiva/release-management-p

@rmconsole-wf
Copy link

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit 35cb73e into master Nov 22, 2019
@rmconsole7-wk rmconsole7-wk deleted the promote_additional_hints_to_errors branch November 22, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants