-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-8543: Promote to warning instead of error. Promote some additional hints. #164
Conversation
Merge Requirements Met ✅Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.
Note: This is a shortened report. Click here to view Rosie's full evaluation. |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
2 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
QA +1 |
+1 from RM |
dead_code
[hint] dead_code #153duplicate_hidden_name
[hint] duplicate_hidden_name #154duplicate_import
[hint] duplicate_import #155duplicate_shown_name
[hint] duplicate_shown_name #156unused_catch_clause
[hint] unused_catch_clause #157unused_catch_stack
[hint] unused_catch_stack #158unused_element
[hint] unused_element #159unused_field
[hint] unused_field #160unused_import
[hint] unused_import #161unused_local_variable
[hint] unused_local_variable #162unused_shown_name
[hint] unused_shown_name #163Since we haven't actually published the 1.0.0 release yet, I added these rules to the
v1.yaml
file and we can just skip 1.0.0 and start by publishing 1.0.1 (i.e. it's not breaking)