Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-2686 dart 2 #20

Merged
merged 4 commits into from
Oct 2, 2018
Merged

AF-2686 dart 2 #20

merged 4 commits into from
Oct 2, 2018

Conversation

robbecker-wf
Copy link
Member

Summary

Fixes for dart 2

  • run travis on dart1 and dart2
  • dart sdk range to include 1&2
  • tweaked dependencies to remove non-dart2 deps

Testing

  • CI passes

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@rmconsole5-wk rmconsole5-wk changed the title dart 2 AF-2686 dart 2 Oct 1, 2018
@corwinsheahan-wf
Copy link
Contributor

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • CI Passes (dart 1 & 2)
  • Security review (if required)
  • Unit tests created/updated
  • All unit tests pass
  • Rosie has run and reports properly the release the ticket will be included in

Merging into master.
@Workiva/release-management-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants