FED-1850 Add Dart 2.19 to GHA matrix #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
rmconsole3-wf
changed the title
kealjones-wk
approved these changes
Nov 2, 2023
| @@ -16,7 +16,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| # Can't run on `stable` (Dart 3) until we're fully null-safe. | |||
| sdk: [2.18.7] | |||
| sdk: [2.18.7, 2.19.6] | |||
There was a problem hiding this comment.
Is there a reason to keep 2.18.7?
There was a problem hiding this comment.
Mm good catch. I don't think there is.
Though, we do currently format under 2.18.7, so we'd have to update that to run on 2.19. To avoid potential merge conflicts with the v7_wip branch, I'd vote to wait to remove it and switch formatting over until after that's merged.
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're only running GitHub Actions in 2.18, and not 2.19 (the latest minor of Dart 2).
Solution
Add 2.19.6 to the GitHub Actions matrix.
Testing
CI passes, including new 2.19.6 run.