Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise_min_dart_sdk_2_19 #175

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

sourcegraph-wk
Copy link
Contributor

Summary

For Dart packages that have migrated to null safety (full or partial)
we can raise the minimum Dart SDK version to 2.19.0 instead of 2.12.0.
This will allow us to take advantage of new language features as soon as
files are migrated to null safety. We've shown that unmigrated consumers
do not have issues consuming packages with a higher minimum Dart SDK version.

Changes

  • Raise minimum Dart SDK version to 2.19.0

QA

  • CI passes

Created by Sourcegraph batch change Workiva/raise_min_dart_sdk_2_19.

@robbecker-wf robbecker-wf marked this pull request as ready for review December 7, 2024 18:26
Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 @Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf merged commit f4bcedf into master Dec 9, 2024
2 checks passed
@rmconsole2-wf rmconsole2-wf deleted the batch/raise_min_dart_sdk_2_19/pdfjs_dart branch December 9, 2024 16:05
This was referenced Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants