Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-10066 Update react / over_react versions for boilerplate migration #84

Merged
merged 4 commits into from
Mar 11, 2020

Conversation

aaronlademann-wf
Copy link
Contributor

Motivation

The migration to the new over_react boilerplate will require updated lower bounds for the react and over_react dependencies for consumer libs.

Changes

Add a standalone interactive codemod that runs before the rest of the migrators that updates the react / over_react dependencies.

NOTE: These versions don't exist yet, but they should / will very soon.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review: @greglittlefield-wf @sydneyjodon-wk @joebingham-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole6-wk rmconsole6-wk changed the title Update react / over_react versions for boilerplate migration CPLAT-10066 Update react / over_react versions for boilerplate migration Mar 11, 2020
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit 728e290 into master Mar 11, 2020
@rmconsole7-wk rmconsole7-wk deleted the boilerplate-pubspec-updater branch March 11, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants