-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-3006 CI fixes and dependency_validator cleanup #291
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
7873323
to
56063e1
Compare
@@ -68,6 +68,8 @@ jobs: | |||
|
|||
- name: Create SBOM Release Asset | |||
uses: anchore/sbom-action@v0 | |||
# This fails if it runs more than once within a given build | |||
if: matrix.sdk != '2.18.7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even need to keep running CI on 2.18.7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question: I don't think so. I thought about ripping that out, but didn't wanna mess with it right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA +1
- CI passes
- SBOM job is step is run exactly once in CI
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
While putting up another PR, I noticed a couple issues:
These seemed worth PRing to master separately.
Changes
package:
imports in comments and strings!ignore
s in config no longer needed with 4.0.0 and newexclude
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: