-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-2094 Add suggestor that replaces useRef with useRefInit #273
FED-2094 Add suggestor that replaces useRef with useRefInit #273
Conversation
6ff4783
to
0bb8dee
Compare
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
0bb8dee
to
1da0b77
Compare
when an argument is passed
1da0b77
to
61272bf
Compare
we will be moving this into an aggregate executable in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 just some questions
test/dart3_suggestors/null_safety_prep/use_ref_init_migration_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 - thank you! Qaing now :loading:
|
||
@override | ||
Future<void> generatePatches() async { | ||
_result = await context.getResolvedUnit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was waiting forever for this to run on DPC and brought it up to Greg and he realized - does this need to be running on resolved AST? It doesn't seem like anything is checking for the package source so it would probably run a lot faster to do this not resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do I just remove the generatePatches
override altogether then? Seems like its an empty method in the base class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm... I figured it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10 ran great on wdesk_sdk and dpc!
@Workiva/release-management-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
useRef
usages that pass an initial value have been changed touseRefInit
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: