CPLAT-4451 Reorder suggestors and improve the UI factory ignore remover

[evanweible-wf]

Description

@maxwellpeterson-wf reported a bug with the codemod where it is possible for certain suggestors to suggest overlapping patches, which is disallowed by the codemod runner. To avoid this, we can simply break up the suggestor list into a few more "phases" that run sequentially. In particular, the cleanup suggestors that remove the backwards-compat-only stuff can be run in their own aggregate suggestor after the other suggestors.

Also included an improvement to the UI factory ignore comment remover that rewrites less (meaning that if you have a factory with a really large doc comment on it, the suggestor won't include that in the diff).

Testing

• CI passes
• Smoke test the dart2_upgrade codemod with and without --backwards-compat on a few large over_react consumers

[aviary2-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[georgelesica-wf]

+1

[evanweible-wf]

QA +1

• CI passes
• Tested against WSD and a few other internal projects

[evanweible-wf]

@Workiva/release-management-p