Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTL-1591: Handle non-arrow intl functions #244

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

alanknight-wk
Copy link
Contributor

Motivation

The intl_suggestors are hard-coded to expect arrow functions, and crash with a parse error if you add one by hand and then try to run the codemod. This is sub-optimal. And pretty easy to fix. One place assumes you can split a string on the '=>' substring, and another place assumes AST structure, but can be easily adapted.

This is analogous to INTL-1589

Changes

Fixes, as above.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@alanknight-wk alanknight-wk changed the title Handle non-arrow intl functions INTL-1591: Handle non-arrow intl functions Sep 19, 2023
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@alanknight-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 0b349b1 into master Sep 20, 2023
4 checks passed
@rmconsole6-wk rmconsole6-wk deleted the handle_non_arrow_functions branch September 20, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants