Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTL-1363 : Give a better error message when something in the intl file is not a method #234

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

alanknight-wk
Copy link
Contributor

Motivation

If you declare something as a field, which people do, then the codemod crashes trying to parse it.
You're not allowed to put fields in there. Or at least we don't want to allow it. But at least make it tell you which declaration was the problem.

Changes

Add a print statement and an explicit throw rather than crashing on a cast error without telling you the problem declaration.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@alanknight-wk alanknight-wk changed the title Give a better error message when something in the intl file is not a method INTL-1363Give a better error message when something in the intl file is not a method Jun 19, 2023
@alanknight-wk alanknight-wk changed the title INTL-1363Give a better error message when something in the intl file is not a method INTL-1363 : Give a better error message when something in the intl file is not a method Jun 19, 2023
@alanknight-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit 45e6948 into master Jun 28, 2023
@rmconsole5-wk rmconsole5-wk deleted the better_error_message branch June 28, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants