-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-1326 Update script updater codemods to include link tags #228
FED-1326 Update script updater codemods to include link tags #228
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
At this point, stable Dart is on version 3 so I think that CI check is expected to fail since our pubspecs are on <3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10 !!
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
Update the codemods added in #212 to also update
link
tags to the new bundle as well as add thecrossorigin=""
attribute.Changes
crossorigin=""
attributeRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
dart pub global activate -s path .
dart pub global run over_react_codemod:rmui_bundle_update --yes-to-all
crossorigin=""
attributeMerge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: