Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-1326 Update script updater codemods to include link tags #228

Merged
merged 4 commits into from
May 30, 2023

Conversation

sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented May 30, 2023

Motivation

Update the codemods added in #212 to also update link tags to the new bundle as well as add the crossorigin="" attribute.

Changes

  • Update dart and html bundle updater suggestors to also update link tags and add the crossorigin="" attribute
  • Write tests.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • CI passing and good test coverage
      • Pull down this branch and run: dart pub global activate -s path .
        • Run the codemod on another repo (maybe wdesk_sdk) and verify that it works as expected:
          • dart pub global run over_react_codemod:rmui_bundle_update --yes-to-all
          • Make sure all link tags are updated to new bundle and with crossorigin="" attribute
          • Make sure any script tags that weren't updated are updated
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review May 30, 2023 21:02
@sydneyjodon-wk sydneyjodon-wk requested review from a team and annawatson-wk and removed request for a team May 30, 2023 21:02
@sydneyjodon-wk
Copy link
Contributor Author

At this point, stable Dart is on version 3 so I think that CI check is expected to fail since our pubspecs are on <3.0.0

Copy link
Contributor

@annawatson-wk annawatson-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 !!

@sydneyjodon-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 3218083 into master May 30, 2023
@rmconsole4-wk rmconsole4-wk deleted the FED-1326-update-script-updater-to-include-links branch May 30, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants