Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTL-1250: Fix for creating two copies of identical messages when they used double quotes #225

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

alanknight-wk
Copy link
Contributor

Motivation

The codemod could create duplicate messages for the same string if the original source code used double quotes. This is because the toSource() method in the analyzer included the quotes for a string literal. We would end up comparing "Search" to 'Search', and failing because the quotes aren't the same. We should consistently handle the strings with quotes removed.

Changes

Add a utility method that gets the string without quotes in a consistent way, and call it. Add tests, and fix one test that seemed to be expecting the incorrect result.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@robbecker-wf
Copy link
Member

QA+1 CI passes with new tests @Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit f3defd6 into master Apr 28, 2023
@rmconsole3-wf rmconsole3-wf deleted the fix_for_duplicates branch April 28, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants