INTL-1250: Fix for creating two copies of identical messages when they used double quotes #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The codemod could create duplicate messages for the same string if the original source code used double quotes. This is because the toSource() method in the analyzer included the quotes for a string literal. We would end up comparing "Search" to 'Search', and failing because the quotes aren't the same. We should consistently handle the strings with quotes removed.
Changes
Add a utility method that gets the string without quotes in a consistent way, and call it. Add tests, and fix one test that seemed to be expecting the incorrect result.
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: