Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-1237: add shouldAddDependencies #217

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

annawatson-wk
Copy link
Contributor

@annawatson-wk annawatson-wk commented Apr 7, 2023

FED-1237

Issue Status

Motivation

When creating the codemod change to update consumers to new RMUI ESM bundle we neglected to include the case in which would add a dependency where there previously wasn't. To remedy this we need to add the shouldAddDependencies flag.

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@rmconsole6-wk rmconsole6-wk changed the title add shouldAddDependencies FED-1237 add shouldAddDependencies Apr 7, 2023
@bender-wk bender-wk changed the title FED-1237 add shouldAddDependencies FED-1237: add shouldAddDependencies Apr 7, 2023
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

  • Ran the codemod locally on web_skin_dart and it only updated the pubspec that already had a rmui dependency

@annawatson-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit 2e6ccfa into master Apr 7, 2023
@rmconsole5-wk rmconsole5-wk deleted the add-shouldAddDependencies branch April 7, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants