INTL-1208: Change parameters typed Function in formattedMessage calls to Object #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Intl.formattedMessage calls take parameters that are Functions. But if the containing function types those arguments as Function it's a problem. This is because Dart then tears off the [call] method from those objects and passes it instead of the object. For React components, which implement call, then we no longer have access to the component, so we can't check properly for how many arguments it wants (by checking explicitly for the known zero-argument functions like Dom.br()). So make the codemod automatically change such arguments from Function to Object.
Changes
In IntlMessage, change the function parameters when reading the file, so rewriting it will use the updated form.
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: