INTL-188: Fix incrementing the usage number of duplicate getters

[alanknight-wk]

Motivation

If the codemod runs into two getters named the same thing, it will add a number to the second one (in this example, it would be dueDate -> 'Due Date' and dueDate1 -> 'Due date'). However, the usage was not reflecting the increment.

Changes

The getter generation passes in an explicit name, because it might be using either the variable name or a name derived from the text. But we were using that name unmodified, instead of using it as the seed to check for an incremented name.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Frontend Frameworks Design member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[aviary2-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[alanknight-wk]

@Workiva/release-management-p

[rmconsole-wf]

+1 from RM