Fix show / hide import updates

Workiva · Oct 30, 2023 · 80a9c4d · 80a9c4d
1 parent e1ff537
commit 80a9c4d
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 6 deletions.
diff --git a/lib/src/unify_package_rename_suggestors/constants.dart b/lib/src/unify_package_rename_suggestors/constants.dart
@@ -15,7 +15,10 @@
 /// Info on a unify_ui import.
 class UnifyImportInfo {
   UnifyImportInfo(this.uri,
-      {this.rmuiUri, this.namespace, this.possibleMuiNamespaces});
+      {this.rmuiUri,
+      this.namespace,
+      this.possibleMuiNamespaces,
+      this.showHideInfo});
 
   /// Unify import URI.
   String uri;
@@ -28,6 +31,9 @@ class UnifyImportInfo {
 
   /// Previous RMUI import URI (if it's different from the unify_ui path).
   String? rmuiUri;
+
+  /// Additional show / hide information used in [importRenamerSuggestorBuilder] to add to updated imports.
+  String? showHideInfo;
 }
 
 /// A list of the standard imports for unify_ui that should be updated.

diff --git a/lib/src/unify_package_rename_suggestors/import_renamer.dart b/lib/src/unify_package_rename_suggestors/import_renamer.dart
@@ -73,8 +73,12 @@ Suggestor importRenamerSuggestorBuilder({
 
       if (newImportUri != null) {
         // Collect info on new imports to add.
-        newImportsInfo
-            .add(UnifyImportInfo(newImportUri, namespace: newNamespace));
+        newImportsInfo.add(UnifyImportInfo(newImportUri,
+            namespace: newNamespace,
+            showHideInfo: import.combinators
+                .map((c) => c.toSource())
+                .toList()
+                .join(' ')));
       }
 
       final prevTokenEnd = import.beginToken.previous?.end;
@@ -96,7 +100,7 @@ Suggestor importRenamerSuggestorBuilder({
           mainLibraryUnitResult.unit, mainLibraryUnitResult.lineInfo);
       yield Patch(
           insertInfo.leadingNewlines +
-              "import '${importInfo.uri}'${importInfo.namespace != null ? ' as ${importInfo.namespace}' : ''};" +
+              "import '${importInfo.uri}'${importInfo.namespace != null ? ' as ${importInfo.namespace}' : ''}${importInfo.showHideInfo != null ? ' ${importInfo.showHideInfo}' : ''};" +
               insertInfo.trailingNewlines,
           insertInfo.offset,
           insertInfo.offset);

diff --git a/test/unify_package_rename_suggestors/import_renamer_test.dart b/test/unify_package_rename_suggestors/import_renamer_test.dart
@@ -130,7 +130,7 @@ void main() {
               import 'package:over_react/over_react.dart' as mui;
               import 'package:react_material_ui/components/badge.dart' as mui;
               import 'package:react_material_ui/components/alert.dart' as something_else;
-              import 'package:react_material_ui/styles/theme_provider.dart' as mui_theme;
+              import 'package:react_material_ui/styles/theme_provider.dart' as mui_theme show UnifyThemeProvider;
           
               content() => Dom.div()();
           ''',
@@ -143,7 +143,7 @@ void main() {
               import 'package:'''
               '''unify_ui/components/badge.dart' as unify;
               import 'package:'''
-              '''unify_ui/styles/theme_provider.dart' as unify_theme;
+              '''unify_ui/styles/theme_provider.dart' as unify_theme show UnifyThemeProvider;
               import 'package:'''
               '''unify_ui/unify_ui.dart' as unify;
               import 'package:'''
@@ -156,6 +156,34 @@ void main() {
         );
       });
 
+      test('with show / hide', () async {
+        await testSuggestor(
+          input: '''
+              import 'package:react_material_ui/react_material_ui.dart' hide Alert;
+              import 'package:react_material_ui/z_alpha_may_break_at_runtime_do_not_release_to_customers.dart' as mui_alpha hide Alert show LinearProgress;
+              import 'package:react_material_ui/components/badge.dart' show Badge hide BadgeColor;
+              import 'package:react_material_ui/components/alert.dart' as something_else show Alert;
+              import 'package:react_material_ui/styles/theme_provider.dart' as mui_theme show UnifyThemeProvider;
+          
+              content() => Dom.div()();
+          ''',
+          expectedOutput: '''
+              import 'package:'''
+              '''unify_ui/components/alert.dart' as something_else show Alert;
+              import 'package:'''
+              '''unify_ui/components/badge.dart' show Badge hide BadgeColor;
+              import 'package:'''
+              '''unify_ui/styles/theme_provider.dart' as unify_theme show UnifyThemeProvider;
+              import 'package:'''
+              '''unify_ui/unify_ui.dart' hide Alert;
+              import 'package:'''
+              '''unify_ui/z_alpha_may_break_at_runtime_do_not_release_to_customers.dart' as alpha_unify hide Alert show LinearProgress;
+              
+              content() => Dom.div()();
+          ''',
+        );
+      });
+
       test('unless the imports are already updated to the new name', () async {
         await testSuggestor(
           input: '''