Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW-147 Change skynet config to check that github workflow passes #94

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

wesleybalvanz-wf
Copy link
Contributor

Motivation

Currently skynet is running the same tests as github workflows instead lets just check and see if github workflows passes or not in skynet.

Changes

Changed skynet config to verify github workflow is successful instead of running the tests in both places.

Release Notes

Change skynet config to verify github workflow is successful.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

evanweible-wf
evanweible-wf previously approved these changes Jun 27, 2022
@evanweible-wf
Copy link
Contributor

QA +1

  • CI passes

@evanweible-wf
Copy link
Contributor

QA +1
@Workiva/release-management-p

@evanweible-wf
Copy link
Contributor

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 3fe1b53 into master Jun 29, 2022
@rmconsole3-wf rmconsole3-wf deleted the fw-147 branch June 29, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants