Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-1716: Workiva Analysis Options v2 #100

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

sourcegraph-wk
Copy link

@sourcegraph-wk sourcegraph-wk commented Sep 13, 2024

FEDX-1716

Issue Status

This PR bumps/adds workiva_analysis_options to v2. This is being done in an effort to adopt consistency in
analysis_options.yaml files across the codebase, and ensure all developers are using the most up to date
functionality that the dart analyzer can provide.

Failing CI will be evaluated by someone from FEDX and resolved. We will reach out when the pr is ready for review.

If you have any questions, concerns, or opinions, please reach out to #support-frontend-dx.

Created by Sourcegraph batch change Workiva/workiva_analysis_options_v2.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@bender-wk bender-wk changed the title Workiva Analysis Options v2 FEDX-1716: Workiva Analysis Options v2 Oct 7, 2024
@sourcegraph-wk sourcegraph-wk force-pushed the batch/fedx/workiva_analysis_options_v2 branch from 942cb48 to c311fce Compare October 16, 2024 18:06
…kiva_analysis_options_v2

# Conflicts:
#	.github/workflows/dart_ci.yaml
@dustinlessard-wf dustinlessard-wf marked this pull request as ready for review October 22, 2024 10:51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo already has a ci configuration: https://github.com/Workiva/fluri/blob/master/.github/workflows/ci.yaml

I think we should be fine to just delete this

@matthewnitschke-wk
Copy link
Contributor

QA +1

  • CI does indeed pass

🚀 @Workiva/release-management-p 🚢

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 9fc2b69 into master Oct 29, 2024
27 checks passed
@rmconsole6-wk rmconsole6-wk deleted the batch/fedx/workiva_analysis_options_v2 branch October 29, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants