Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show prompt only when creating new events #79

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Show prompt only when creating new events #79

merged 1 commit into from
Feb 15, 2024

Conversation

trymebytes
Copy link
Collaborator

Fixes #70

psrpinto
psrpinto approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works 👌

@trymebytes trymebytes merged commit 8e1251e into trunk Feb 15, 2024
2 checks passed
@trymebytes trymebytes deleted the no-update-prompt branch February 15, 2024 12:22
@amieiro
Copy link
Collaborator

amieiro commented Feb 15, 2024

If you save the draft, and then you publish the event, you get a prompt. We can address this issue in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psrpinto psrpinto psrpinto approved these changes

@akirk akirk Awaiting requested review from akirk

@amieiro amieiro Awaiting requested review from amieiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating an event should not show a confirmation dialog
3 participants
@trymebytes @amieiro @psrpinto