-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleted events page #371
base: trunk
Are you sure you want to change the base?
Deleted events page #371
Conversation
f06ff54
to
4eafc69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it and the look and feel is nice.
Some comments:
- I think we should move the "Edit icon" to a button like the other two ("Restore" and "Delete permanently").
- I think we should have a confirm button in both buttons: something like "Are you sure you want to delete this event", and something similar for the "Restore" button. These actions are important, and the "Delete" is destructive, so I think a confirmation button will improve the UI.
- When I click in the "Restore" button in the "WordCamp Kerala" event, the event is not restored.
4bdc5a7
to
2c86571
Compare
eee087b
to
6f444bf
Compare
@trymebytes That's a lot of icons now next to the title (I know this is just for admins but still). Can you try some UI variations with putting them in a dedicated column or just right aligning them? Thanks! |
Thanks! Visually I like version 1 better, what do you think? |
I agree, it's visually appealing and user-experience wise, I also prefer it to version 2. |
Fixes #368
Before
After