Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted events page #371

Open
wants to merge 13 commits into
base: trunk
Choose a base branch
from
Open

Deleted events page #371

wants to merge 13 commits into from

Conversation

trymebytes
Copy link
Collaborator

@trymebytes trymebytes commented Oct 15, 2024

Fixes #368

Before

image

After
Screenshot 2024-10-16 at 18 55 34

@trymebytes trymebytes changed the base branch from trunk to fix-navigation October 15, 2024 17:12
@trymebytes trymebytes marked this pull request as ready for review October 16, 2024 18:12
@trymebytes trymebytes requested a review from akirk October 17, 2024 08:56
@amieiro amieiro self-requested a review November 5, 2024 07:32
Copy link
Collaborator

@amieiro amieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and the look and feel is nice.

image

Some comments:

  • I think we should move the "Edit icon" to a button like the other two ("Restore" and "Delete permanently").
  • I think we should have a confirm button in both buttons: something like "Are you sure you want to delete this event", and something similar for the "Restore" button. These actions are important, and the "Delete" is destructive, so I think a confirmation button will improve the UI.
  • When I click in the "Restore" button in the "WordCamp Kerala" event, the event is not restored.

@akirk
Copy link
Member

akirk commented Nov 18, 2024

We could also use icons instead of buttons?

For example for restoring:

Screenshot 2024-11-18 at 12 23 23

And delete permanently:
Screenshot 2024-11-18 at 12 24 26

Base automatically changed from fix-navigation to trunk November 19, 2024 15:41
@trymebytes
Copy link
Collaborator Author

Updated view
image

@akirk
Copy link
Member

akirk commented Dec 2, 2024

@trymebytes That's a lot of icons now next to the title (I know this is just for admins but still). Can you try some UI variations with putting them in a dedicated column or just right aligning them? Thanks!

@trymebytes
Copy link
Collaborator Author

Here are the variations;

Mockup 1
Screenshot 2024-12-02 at 14 54 07

Mockup 2
Screenshot 2024-12-02 at 14 17 00

cc @akirk @amieiro

@akirk
Copy link
Member

akirk commented Dec 2, 2024

Thanks! Visually I like version 1 better, what do you think?

@trymebytes
Copy link
Collaborator Author

I agree, it's visually appealing and user-experience wise, I also prefer it to version 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update design for deleted events page
3 participants