Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing navigation links #366

Merged
merged 11 commits into from
Nov 19, 2024
Merged

Add missing navigation links #366

merged 11 commits into from
Nov 19, 2024

Conversation

trymebytes
Copy link
Collaborator

@trymebytes trymebytes commented Oct 3, 2024

Fixes #364
Before
image

After
image

@trymebytes trymebytes changed the base branch from trunk to event-form-block October 3, 2024 13:38
Base automatically changed from event-form-block to trunk October 7, 2024 13:26
@trymebytes trymebytes marked this pull request as ready for review October 7, 2024 19:45
@trymebytes trymebytes requested review from akirk and amieiro October 7, 2024 19:46
amieiro
amieiro previously requested changes Nov 5, 2024
Copy link
Collaborator

@amieiro amieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest two changes:

  • Add a vertical separator between both links.
  • Remove the link in the current page: the user is in the "My Events" page, so she doesn't need this link.

image

@trymebytes
Copy link
Collaborator Author

Here is the updated view;

linknav

@trymebytes trymebytes requested a review from amieiro November 14, 2024 15:38
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me!

@trymebytes trymebytes dismissed amieiro’s stale review November 19, 2024 15:41

Fixed, thank you!

@trymebytes trymebytes merged commit fefa95f into trunk Nov 19, 2024
3 checks passed
@trymebytes trymebytes deleted the fix-navigation branch November 19, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Navigation items to My Events
3 participants