Support mutliple sites when using browser storage #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
approved these changes
May 29, 2024
| create: true, | ||
| }); | ||
| virtualOpfsDir = await virtualOpfsRoot.getDirectoryHandle( | ||
| startupOptions.siteSlug, |
There was a problem hiding this comment.
Let's prefix that with something or, even better, put it in /sites/ directory. This way we'll be able to safely use the rest of OPFS without risking finding a WordPress site in a random location.
There was a problem hiding this comment.
I added prefixes. If I moved sites to a subfolder the default WordPress site would be special or I had to be moved, so prefixes seemed cleaner.
bgrgicak
added
[Type] Enhancement
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
It adds support for storing multiple sites in browser storage.
Up until this PR only one site could be stored in a browser. If you wanted to add another site, you would need to overwrite the first one. With this PR you are able to add more sites without affecting existing sites.
What problem is it solving?
There is no way to run multiple Playground sites with browser storage enabled because sites override each other.
How is the problem addressed?
By adding a
site-slugquery argument that allows users to specify which site to load.Testing Instructions