Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display field description #169

Merged
merged 14 commits into from
Dec 18, 2024
Merged

Display field description #169

merged 14 commits into from
Dec 18, 2024

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Dec 16, 2024

Fixes #157

This PR displays the description of fields, coming from schema.json. I also took the opportunity to simplify some places of the code related to handling fields.

Screen capture

Screenshot 2024-12-17 at 17 08 15

@psrpinto psrpinto changed the base branch from trunk to no-hardcode-subject-type December 16, 2024 16:44
@psrpinto psrpinto self-assigned this Dec 16, 2024
@psrpinto psrpinto linked an issue Dec 16, 2024 that may be closed by this pull request
Base automatically changed from no-hardcode-subject-type to trunk December 16, 2024 16:49
@psrpinto psrpinto force-pushed the ui-fields-extra-info branch 2 times, most recently from 87540c7 to 754205c Compare December 17, 2024 15:32
@psrpinto
Copy link
Member Author

I will wait for #170 to be merged, and adapt this one as needed.

@psrpinto psrpinto marked this pull request as ready for review December 17, 2024 17:50
@psrpinto psrpinto requested a review from ashfame December 17, 2024 17:50
@psrpinto psrpinto force-pushed the ui-fields-extra-info branch from 2929015 to a2b60be Compare December 18, 2024 12:29
@psrpinto
Copy link
Member Author

I force-pushed to fix conflicts. Only the last commit is new.

@psrpinto psrpinto requested review from ashfame and removed request for ashfame December 18, 2024 12:31
Copy link
Member

@ashfame ashfame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@psrpinto psrpinto merged commit 676272f into trunk Dec 18, 2024
3 checks passed
@psrpinto psrpinto deleted the ui-fields-extra-info branch December 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display field description in the UI
2 participants