Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprints are broken when the name of a field in the schema changes #159

Open
psrpinto opened this issue Dec 12, 2024 · 2 comments
Open
Labels
bug Something isn't working frontend
Milestone

Comments

@psrpinto
Copy link
Member

Steps to reproduce

  • npm run start:firefox
  • Click "Import Blog Posts"
  • Navigate to the screen where one clicks around to fill the blogpost
  • Select the title of the post
  • In your editor, rename the title field in ./schema/subjects/blog-post.json to something other than title. Note that it's fields.title we're modifying, not the top-level title.
  • In your terminal, do npm run build:schema
  • In your editor, add some blank lines in a TypeScript file and save it, so that the extension reloads
  • The following error is displayed
Unexpected Application Error!
field is undefined

SingleFieldEditor@moz-extension://1c528d92-66fa-4917-afc2-4888dbede0f5/app.js:375190:1212
@psrpinto psrpinto added this to the MVP milestone Dec 12, 2024
@psrpinto psrpinto added the bug Something isn't working label Dec 12, 2024
@psrpinto psrpinto changed the title Blueprints are broken when the name of a field changes Blueprints are broken when the name of a field in the schema changes Dec 12, 2024
@ashfame
Copy link
Member

ashfame commented Dec 16, 2024

Documenting what we discussed: This is probably not a consideration if we can just make up a rule of not changing the field once defined. And if ever need to, wiping out the import and starting fresh could be a possible route to move forward.

I personally don't think it warrants data migration as possible handling because of changed fields.

@psrpinto
Copy link
Member Author

I believe this one might be fixed, but testing it requires first addressing #174. I'll test this once a fix for #174 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

2 participants