Drag and drop: fix misplaced drop indicator #67434
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
changed the title
|
Size Change: +7 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8f489b4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12089232119
|
youknowriad
reviewed
Nov 29, 2024
| if ( isRTL() ) { | ||
| // non vertical, rtl | ||
| left = nextRect ? nextRect.right : previousRect.left; | ||
| width = |
There was a problem hiding this comment.
I don't understand why you removed the isRTL case?
There was a problem hiding this comment.
We could move it inline on L135 - isRTL() ? previousRect.left - nextRect.right : nextRect.left - previousRect.right;
There was a problem hiding this comment.
I misread it, I though it's the same and only left was different.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Dec 2, 2024
|
Thanks! |
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ntsekouras <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ntsekouras <[email protected]>
ramonjd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
It's a bug.
How?
We should ensure the width of the popover anchor does not become negative when the next and previous item are on a different line.
Perhaps we should explore showing the inserter in between the line as a follow-up.
Testing Instructions
Create a block with inner block showing horizontally and make the items wrap. Drag an item to the end of the first line.
Testing Instructions for Keyboard
Screenshots or screencast