Site Editor: speed up load by preloading home and front-page templates #66579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -181 B (-0.01%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in db599cc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11599710943
|
ellatrix
force-pushed
the
try/preload-home-front-templates
branch
from
3885404 to
7498e46
Compare
ellatrix
changed the base branch from
trunk
to
remove/incorrect-selector-call
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
commented
Oct 30, 2024
| if ( !! frontPageTemplateId ) { | ||
| return frontPageTemplateId; | ||
| } | ||
| return frontPageTemplateId; |
There was a problem hiding this comment.
The previous frontPageTemplateId seems to only find the actual front-page template instead of going through the hierarchy and return wherever is the fallback when it does not exist.
|
We introduced server-side resolution for similar cases a while back, but it was later reverted in favor of client-side resolutions. See #38817. |
|
@Mamaduka I'm not sure if it's quite the same. That PR seems to be about a different use case? What was the revert PR and reason, I didn't see it linked. |
I don't recall exactly. It was part of the larger refactors Riad did for the site editor. In any case, it shouldn't be a blocker here. |
ellatrix
force-pushed
the
remove/incorrect-selector-call
branch
from
f208185 to
d366821
Compare
ellatrix
force-pushed
the
try/preload-home-front-templates
branch
from
09d02da to
db599cc
Compare
ellatrix
changed the title
Mamaduka
reviewed
Oct 31, 2024
| if ( !! frontPageTemplateId ) { | ||
| return frontPageTemplateId; | ||
| } | ||
| return getDefaultTemplateId( { slug: 'front-page' } ); |
There was a problem hiding this comment.
Should we leave previous logic/step related comments? They should still apply, right?
There was a problem hiding this comment.
I don't think so? This returns the resolving selector right away so it will either return undefined or the ID. Worth noting it's already the same below for postsPageId which already returned a resolving selector before.
Mamaduka
reviewed
Oct 31, 2024
packages/edit-site/src/components/sync-state-with-url/use-init-edited-entity-from-url.js
Show resolved
Hide resolved
ellatrix
force-pushed
the
try/preload-home-front-templates
branch
from
87a698f to
111a7f4
Compare
ellatrix
requested review from
artemiomorales,
michalczaplinski,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
ellatrix
changed the base branch from
remove/incorrect-selector-call
to
trunk
ellatrix
force-pushed
the
try/preload-home-front-templates
branch
from
111a7f4 to
3a52f7c
Compare
|
@ellatrix, this breaks the Site Editor when no query arguments are provided: edit: only on Safari (macOS) 
The notice reads "You attempted to edit an item that doesn't exist. Perhaps it was deleted?". |
Odd, I'm pretty sure I tested various scenarios accessing the Site Editor and should've been picked up by e2e tests as well. |
|
Talked to Ella and we can both repro using Safari on macOS, but not elsewhere. |
This was referenced Oct 31, 2024
6 tasks
|
This introduced a change in behavior for me when |
|
#66687 is also an issue I've stumbled upon |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
WordPress#66579) Co-authored-by: ellatrix <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Depends on #66581.
The
front-pageandhometemplate IDs (or their fallbacks) should be preloaded for the Site Editor. This avoids a request to figure out which template is used.Why?
Avoid a blocking request (
?_wp-find-template=true) that slows down Site Editor loading.How?
We remove the resolver that triggers the request entirely and use
/wp/v2/templates/lookupinstead to preload the info.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast