-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Media Text: Always show images on top on mobile. #24468
Merged
jorgefilipecosta
merged 1 commit into
master
from
fix/always-show-images-on-top-on-mobile-inside-media-text-block
Aug 11, 2020
Merged
Fix: Media Text: Always show images on top on mobile. #24468
jorgefilipecosta
merged 1 commit into
master
from
fix/always-show-images-on-top-on-mobile-inside-media-text-block
Aug 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
A suggestion for improvement.
Needs Dev Note
Requires a developer note for a major WordPress release cycle
labels
Aug 10, 2020
jorgefilipecosta
requested review from
ajitbohra,
Soean and
talldan
as code owners
August 10, 2020 14:22
Size Change: -21 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
kjellr
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, this is working great for me. 👍
jorgefilipecosta
deleted the
fix/always-show-images-on-top-on-mobile-inside-media-text-block
branch
August 11, 2020 13:47
tellthemachines
removed
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Nov 18, 2020
This one works please see both comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Design Feedback
Needs general design feedback.
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #14283
In #14283, it seems we arrived at a consensus that on mobile the media & text images should appear on top (and the display image on left/right option should be ignored).
This PR applies that change to the block.
How has this been tested?
I two added the media & text block.
In one I made the images appear on the right and it the other on the left (default).
I resized the window to a mobile view (650px) I verified that in both editor and frontend and for both blocks the images appear on the top.