Try switching wordpress install in travis to wp-env

[noahtallen]

Description

Curious to see if this works and what would need to be changed. I'm using npm run wp-env... because I think that uses the local wp-env in the git checkout. So that would help us make sure that wp-env keeps working.

phpunit tests will probably keep failing. That depends on #20090

I spun this up because all our e2e tests started failing because of an issue in wordpress-develop.

How has this been tested?

Travis

[github-actions]

Size Change: 0 B

Total Size: 827 kB

ℹ️ View Unchanged

Filename	Size	Change
build/a11y/index.js	1.02 kB	0 B
build/annotations/index.js	3.62 kB	0 B
build/api-fetch/index.js	4.08 kB	0 B
build/autop/index.js	2.82 kB	0 B
build/blob/index.js	620 B	0 B
build/block-directory/index.js	6.63 kB	0 B
build/block-directory/style-rtl.css	764 B	0 B
build/block-directory/style.css	764 B	0 B
build/block-editor/index.js	104 kB	0 B
build/block-editor/style-rtl.css	10.6 kB	0 B
build/block-editor/style.css	10.6 kB	0 B
build/block-library/editor-rtl.css	7.12 kB	0 B
build/block-library/editor.css	7.12 kB	0 B
build/block-library/index.js	115 kB	0 B
build/block-library/style-rtl.css	7.38 kB	0 B
build/block-library/style.css	7.38 kB	0 B
build/block-library/theme-rtl.css	683 B	0 B
build/block-library/theme.css	685 B	0 B
build/block-serialization-default-parser/index.js	1.88 kB	0 B
build/block-serialization-spec-parser/index.js	3.1 kB	0 B
build/blocks/index.js	48.1 kB	0 B
build/components/index.js	181 kB	0 B
build/components/style-rtl.css	17 kB	0 B
build/components/style.css	16.9 kB	0 B
build/compose/index.js	6.66 kB	0 B
build/core-data/index.js	11.4 kB	0 B
build/data-controls/index.js	1.29 kB	0 B
build/data/index.js	8.43 kB	0 B
build/date/index.js	5.47 kB	0 B
build/deprecated/index.js	772 B	0 B
build/dom-ready/index.js	568 B	0 B
build/dom/index.js	3.1 kB	0 B
build/edit-navigation/index.js	4.42 kB	0 B
build/edit-navigation/style-rtl.css	618 B	0 B
build/edit-navigation/style.css	617 B	0 B
build/edit-post/index.js	28 kB	0 B
build/edit-post/style-rtl.css	12.2 kB	0 B
build/edit-post/style.css	12.2 kB	0 B
build/edit-site/index.js	12.1 kB	0 B
build/edit-site/style-rtl.css	5.22 kB	0 B
build/edit-site/style.css	5.22 kB	0 B
build/edit-widgets/index.js	8.37 kB	0 B
build/edit-widgets/style-rtl.css	4.69 kB	0 B
build/edit-widgets/style.css	4.69 kB	0 B
build/editor/editor-styles-rtl.css	425 B	0 B
build/editor/editor-styles.css	428 B	0 B
build/editor/index.js	44.3 kB	0 B
build/editor/style-rtl.css	5.07 kB	0 B
build/editor/style.css	5.08 kB	0 B
build/element/index.js	4.65 kB	0 B
build/escape-html/index.js	734 B	0 B
build/format-library/index.js	7.63 kB	0 B
build/format-library/style-rtl.css	502 B	0 B
build/format-library/style.css	502 B	0 B
build/hooks/index.js	2.14 kB	0 B
build/html-entities/index.js	622 B	0 B
build/i18n/index.js	3.56 kB	0 B
build/is-shallow-equal/index.js	710 B	0 B
build/keyboard-shortcuts/index.js	2.51 kB	0 B
build/keycodes/index.js	1.94 kB	0 B
build/list-reusable-blocks/index.js	3.12 kB	0 B
build/list-reusable-blocks/style-rtl.css	226 B	0 B
build/list-reusable-blocks/style.css	226 B	0 B
build/media-utils/index.js	5.29 kB	0 B
build/notices/index.js	1.79 kB	0 B
build/nux/index.js	3.4 kB	0 B
build/nux/style-rtl.css	616 B	0 B
build/nux/style.css	613 B	0 B
build/plugins/index.js	2.56 kB	0 B
build/primitives/index.js	1.5 kB	0 B
build/priority-queue/index.js	789 B	0 B
build/redux-routine/index.js	2.85 kB	0 B
build/rich-text/index.js	14.8 kB	0 B
build/server-side-render/index.js	2.68 kB	0 B
build/shortcode/index.js	1.7 kB	0 B
build/token-list/index.js	1.28 kB	0 B
build/url/index.js	4.02 kB	0 B
build/viewport/index.js	1.84 kB	0 B
build/warning/index.js	1.14 kB	0 B
build/wordcount/index.js	1.18 kB	0 B

_{compressed-size-action}

[epiqueras]

We need to land #20090 first.

What is missing there?

[noahtallen]

#20090 (comment)

basically just need to make sure the API for exposing through wp-scripts is solid. otherwise it should work

[noahtallen]

This is interesting. I've been seeing these "can't update react state on an unmounted component" failures locally for quite a while and it's been really hard to get around them. see: #17355

Anyways, these didn't really occur in CI that often, which was nice (but suprising). Now that we use wp-env here, it looks like most tests are failing because of that error.

[noahtallen]

also getting some warnings related to deprecated react APIs. Not sure what the difference is running them against wordpress develop vs wp-env.

[epiqueras]

basically just need to make sure the API for exposing through wp-scripts is solid. otherwise it should work

We shouldn't expose it through wp-scripts. wp-scripts does not have a PHP unit test command, wp-scripts env does. We should just call wp-env directly instead in package.json.

Anyways, these didn't really occur in CI that often, which was nice (but suprising). Now that we use wp-env here, it looks like most tests are failing because of that error.
also getting some warnings related to deprecated react APIs. Not sure what the difference is running them against wordpress develop vs wp-env.

SCRIPT_DEBUG needs to be false.

[noahtallen]

Sounds great 👍

[noahtallen]

SCRIPT_DEBUG needs to be false.

we likely want this to stay true in dev mode, so I'll look into what we discussed with separate dev/testing environments. We could get around it in the install step, but i think it makes sense to knock out this other task.

[talldan]

There's #20280 which I worked on a while ago and does the same thing. E2E tests are passing there (though PHP tests are failing for some reason.)

[noahtallen]

closing in favor of #20280 which has been around for a lot longer and has some more things solved already :)