Components: Add test on SlotFill #21226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
|
Size Change: 0 B Total Size: 857 kB ℹ️ View Unchanged
|
diegohaz
commented
Mar 28, 2020
| @@ -25,7 +25,6 @@ function useSlotRegistry() { | |||
|
|
|||
| const unregisterSlot = useCallback( ( name, ref ) => { | |||
| setSlots( ( prevSlots ) => { | |||
| // eslint-disable-next-line no-unused-vars | |||
| const { [ name ]: slot, ...nextSlots } = prevSlots; | |||
There was a problem hiding this comment.
We're using the slot variable, so the comment above is unnecessary.
diegohaz
added
[Package] Components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up of #21205. It adds a test to confirm that removing a Slot that has been already removed doesn't throw an error.
I had to use
react-domandreact-dom/test-utilsbecausereact-test-rendererdoesn't support React Portal (related: #20428).How has this been tested?
npm run test-unitThe first commit in this PR shows the failing case.
https://travis-ci.com/github/WordPress/gutenberg/jobs/306589748#L4704